netdev - Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230413090040.44aa0d55@kernel.org>
Date:   Thu, 13 Apr 2023 09:00:40 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Corinna Vinschen <vinschen@...hat.com>
Cc:     netdev@...r.kernel.org,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        alexandre.torgue@...s.st.com, Jose Abreu <joabreu@...opsys.com>
Subject: Re: [PATCH net-next] net: stmmac: propagate feature flags to vlan

On Thu, 13 Apr 2023 17:25:56 +0200 Corinna Vinschen wrote:
> I tested that I can, for instance, set and reset the tx-checksumming
> flag with ethtool -K.  As for TSO, I checked the source code, and the
> function stmmac_tso_xmit handles VLANs just fine.  While different
> NICs supported by stmmac have different offload features, there's no
> indication in the driver source that VLANs have less offloading features
> than a non-VLAN connection on the same HW.  Admittedly, I never saw
> documentation explicitely claiming this.
> 
> If that's not sufficient, testing will take another day or two, because
> I have to ask for a remote test setup first.

Testing would be great, I think it's worth waiting for that.