netdev - Re: [PATCH net-next v2 02/15] idpf: add module register and probe functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c95589a0-e25b-e8be-ebbe-7f99d801c230@intel.com>
Date:   Thu, 13 Apr 2023 11:58:44 -0700
From:   "Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:     Leon Romanovsky <leon@...nel.org>
CC:     Pavan Kumar Linga <pavan.kumar.linga@...el.com>,
        <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
        <joshua.a.hay@...el.com>, <sridhar.samudrala@...el.com>,
        <jesse.brandeburg@...el.com>, <anthony.l.nguyen@...el.com>,
        <willemb@...gle.com>, <decot@...gle.com>, <pabeni@...hat.com>,
        <kuba@...nel.org>, <edumazet@...gle.com>, <davem@...emloft.net>,
        Phani Burra <phani.r.burra@...el.com>,
        Alan Brady <alan.brady@...el.com>,
        Madhu Chittim <madhu.chittim@...el.com>,
        Shailendra Bhatnagar <shailendra.bhatnagar@...el.com>
Subject: Re: [PATCH net-next v2 02/15] idpf: add module register and probe
 functionality



On 4/12/2023 11:03 PM, Leon Romanovsky wrote:
> On Wed, Apr 12, 2023 at 04:10:18PM -0700, Tantilov, Emil S wrote:
>>
>>
>> On 4/11/2023 5:36 AM, Leon Romanovsky wrote:
>>> On Mon, Apr 10, 2023 at 06:13:41PM -0700, Pavan Kumar Linga wrote:
>>>> From: Phani Burra <phani.r.burra@...el.com>
>>>>
>>>> Add the required support to register IDPF PCI driver, as well as
>>>> probe and remove call backs. Enable the PCI device and request
>>>> the kernel to reserve the memory resources that will be used by the
>>>> driver. Finally map the BAR0 address space.
>>>>
>>>> PCI IDs table is intentionally left blank to prevent the kernel from
>>>> probing the device with the incomplete driver. It will be added
>>>> in the last patch of the series.
>>>>
>>>> Signed-off-by: Phani Burra <phani.r.burra@...el.com>
>>>> Co-developed-by: Alan Brady <alan.brady@...el.com>
>>>> Signed-off-by: Alan Brady <alan.brady@...el.com>
>>>> Co-developed-by: Madhu Chittim <madhu.chittim@...el.com>
>>>> Signed-off-by: Madhu Chittim <madhu.chittim@...el.com>
>>>> Co-developed-by: Shailendra Bhatnagar <shailendra.bhatnagar@...el.com>
>>>> Signed-off-by: Shailendra Bhatnagar <shailendra.bhatnagar@...el.com>
>>>> Co-developed-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
>>>> Signed-off-by: Pavan Kumar Linga <pavan.kumar.linga@...el.com>
>>>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>>>> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
>>>> ---
>>>>    drivers/net/ethernet/intel/Kconfig            | 11 +++
>>>>    drivers/net/ethernet/intel/Makefile           |  1 +
>>>>    drivers/net/ethernet/intel/idpf/Makefile      | 10 ++
>>>>    drivers/net/ethernet/intel/idpf/idpf.h        | 27 ++++++
>>>>    .../net/ethernet/intel/idpf/idpf_controlq.h   | 14 +++
>>>>    drivers/net/ethernet/intel/idpf/idpf_lib.c    | 96 +++++++++++++++++++
>>>>    drivers/net/ethernet/intel/idpf/idpf_main.c   | 70 ++++++++++++++
>>>>    7 files changed, 229 insertions(+)
>>>>    create mode 100644 drivers/net/ethernet/intel/idpf/Makefile
>>>>    create mode 100644 drivers/net/ethernet/intel/idpf/idpf.h
>>>>    create mode 100644 drivers/net/ethernet/intel/idpf/idpf_controlq.h
>>>>    create mode 100644 drivers/net/ethernet/intel/idpf/idpf_lib.c
>>>>    create mode 100644 drivers/net/ethernet/intel/idpf/idpf_main.c
>>>
>>> <...>
> 
> <...>
> 
>>>> +/**
>>>> + * idpf_probe - Device initialization routine
>>>> + * @pdev: PCI device information struct
>>>> + * @ent: entry in idpf_pci_tbl
>>>> + *
>>>> + * Returns 0 on success, negative on failure
>>>> + */
>>>> +static int idpf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>>>> +{
>>>> +	struct idpf_adapter *adapter;
>>>> +
>>>> +	adapter = devm_kzalloc(&pdev->dev, sizeof(*adapter), GFP_KERNEL);
>>>
>>> Why devm_kzalloc() and not kzalloc?
>> It provides managed memory allocation on probe, which seems to be the
>> preferred method in that case.
> 
> I don't think so, as PCI probe/remove has very clear lifetime model and
> doesn't need garbage collection memory logic. In general, it is better
> to avoid devm_*() APIs as they hide error unwind flows.

We'll remove it in v3.

Thanks,
Emil

> Thanks