netdev - Re: [RFC PATCH v2 net-next 6/7] net: ethtool: add a mutex protecting RSS contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a628b861-47a9-44d2-a717-5268dc5b47f6@lunn.ch>
Date:   Thu, 13 Apr 2023 23:58:36 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Edward Cree <ecree.xilinx@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>, edward.cree@....com,
        linux-net-drivers@....com, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        habetsm.xilinx@...il.com, sudheer.mogilappagari@...el.com
Subject: Re: [RFC PATCH v2 net-next 6/7] net: ethtool: add a mutex protecting
 RSS contexts

> (Idk, maybe sfc is just uniquely complex and messy.  It wouldn't be
>  the first time.)

Hi Ed

Have you looked at other drivers? It would be bad to design an API
around a messy driver. Maybe this is an opportunity to learn from
other drivers and come up with something cleaner for SFC?

      Andrew