netdev - Re: [PATCH net-next v5 5/5] macsec: Don't rely solely on the dst MAC address to identify destination MACsec device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230414080051.004e2a67@kernel.org>
Date:   Fri, 14 Apr 2023 08:00:51 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Emeel Hakim <ehakim@...dia.com>
Cc:     <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
        <sd@...asysnail.net>, <netdev@...r.kernel.org>, <leon@...nel.org>
Subject: Re: [PATCH net-next v5 5/5] macsec: Don't rely solely on the dst
 MAC address to identify destination MACsec device

On Thu, 13 Apr 2023 13:56:22 +0300 Emeel Hakim wrote:
> +			struct macsec_rx_sc *rx_sc = (md_dst && md_dst->type == METADATA_MACSEC) ?
> +						     find_rx_sc(&macsec->secy,
> +								md_dst->u.macsec_info.sci) : NULL;

Just a coding nit, in addition to Subbaraya's question:
why use a ternary operator if the entire expression ends up being 
3 lines of code? :| And well above 80 char.