netdev - RE: [PATCH net-next v2 0/6] ice: lower CPU usage with GNSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2023 17:29:15 +0000
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@...el.com>
To:     mschmidt <mschmidt@...hat.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Kolacinski, Karol" <karol.kolacinski@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        Simon Horman <simon.horman@...igine.com>,
        "Michalik, Michal" <michal.michalik@...el.com>,
        poros <poros@...hat.com>, Andrew Lunn <andrew@...n.ch>
Subject: RE: [PATCH net-next v2 0/6] ice: lower CPU usage with GNSS

>From: Michal Schmidt <mschmidt@...hat.com>
>Sent: Wednesday, April 12, 2023 10:19 AM
>
>This series lowers the CPU usage of the ice driver when using its
>provided /dev/gnss*.
>
>v2:
> - Changed subject of patch 1. Requested by Andrew Lunn.
> - Added patch 2 to change the polling interval as recommended by Intel.
> - Added patch 3 to remove sq_cmd_timeout as suggested by Simon Horman.
>
>Michal Schmidt (6):
>  ice: do not busy-wait to read GNSS data
>  ice: increase the GNSS data polling interval to 20 ms
>  ice: remove ice_ctl_q_info::sq_cmd_timeout
>  ice: sleep, don't busy-wait, for ICE_CTL_Q_SQ_CMD_TIMEOUT
>  ice: remove unused buffer copy code in ice_sq_send_cmd_retry()
>  ice: sleep, don't busy-wait, in the SQ send retry loop
>
> drivers/net/ethernet/intel/ice/ice_common.c   | 29 +++++--------
> drivers/net/ethernet/intel/ice/ice_controlq.c | 12 +++---
> drivers/net/ethernet/intel/ice/ice_controlq.h |  3 +-
> drivers/net/ethernet/intel/ice/ice_gnss.c     | 42 +++++++++----------
> drivers/net/ethernet/intel/ice/ice_gnss.h     |  3 +-
> 5 files changed, 36 insertions(+), 53 deletions(-)
>
>--
>2.39.2

In general I couldn't find any issues with the series.
Thank you all for suggestions and your work on this.

Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>