netdev - Re: [PATCH net-next] lib/win_minmax: export symbol of minmax_running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Apr 2023 02:27:36 +0000
From:   Yixin Shen <bobankhshen@...il.com>
To:     leon@...nel.org
Cc:     akpm@...ux-foundation.org, bobankhshen@...il.com,
        davem@...emloft.net, edumazet@...gle.com,
        linux-kernel@...r.kernel.org, ncardwell@...gle.com,
        netdev@...r.kernel.org, rdunlap@...radead.org
Subject: Re: [PATCH net-next] lib/win_minmax: export symbol of minmax_running_min

> Please provide in-tree kernel user for that EXPORT_SYMBOL.

It is hard to provide such an in-tree kernel user. We are trying to
implement newer congestion control algorithms as dynamically loaded modules.
For example, Copa(NSDI'18) which is adopted by Facebook needs to maintain
such windowed min filters. Althought it is true that we can just
copy-and-paste the code inside lib/win_minmax, it it more convenient to
give the same status of minmax_running_min as minmax_running_max.
It is confusing that only minmax_running_max is exported.
If this patch is rejected because the changes are too significant,
I can also understand.

Thanks.