netdev - RE: [PATCH v1 1/1] net: macb: Shorten max_tx_len to 4KiB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR12MB47731CE29417CF5B4879D3429E999@BYAPR12MB4773.namprd12.prod.outlook.com>
Date:   Fri, 14 Apr 2023 09:14:40 +0000
From:   "Katakam, Harini" <harini.katakam@....com>
To:     "Nicolas.Ferre@...rochip.com" <Nicolas.Ferre@...rochip.com>,
        "Daire.McNamara@...rochip.com" <Daire.McNamara@...rochip.com>,
        "Claudiu.Beznea@...rochip.com" <Claudiu.Beznea@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Conor.Dooley@...rochip.com" <Conor.Dooley@...rochip.com>
CC:     "Simek, Michal" <michal.simek@....com>,
        "roman.gushchin@...ux.dev" <roman.gushchin@...ux.dev>,
        "jacob.e.keller@...el.com" <jacob.e.keller@...el.com>
Subject: RE: [PATCH v1 1/1] net: macb: Shorten max_tx_len to 4KiB - 56 on mpfs



> -----Original Message-----
> From: Nicolas.Ferre@...rochip.com <Nicolas.Ferre@...rochip.com>
> Sent: Friday, April 14, 2023 2:30 PM
> To: Daire.McNamara@...rochip.com; Claudiu.Beznea@...rochip.com;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; netdev@...r.kernel.org;
> Conor.Dooley@...rochip.com; Nicolas.Ferre@...rochip.com
> Cc: Katakam, Harini <harini.katakam@....com>; Simek, Michal
> <michal.simek@....com>; roman.gushchin@...ux.dev;
> jacob.e.keller@...el.com
> Subject: Re: [PATCH v1 1/1] net: macb: Shorten max_tx_len to 4KiB - 56 on
> mpfs
> 
> On 13/04/2023 at 20:03, daire.mcnamara@...rochip.com wrote:
> > From: Daire McNamara <daire.mcnamara@...rochip.com>
> >
> > On mpfs, with SRAM configured for 4 queues, setting max_tx_len to
> > GEM_TX_MAX_LEN=0x3f0 results multiple AMBA errors.
> > Setting max_tx_len to (4KiB - 56) removes those errors.
> >
> > The details are described in erratum 1686 by Cadence
> >
> > The max jumbo frame size is also reduced for mpfs to (4KiB - 56).
> >
> > Signed-off-by: Daire McNamara <daire.mcnamara@...rochip.com>
> 
> Looks good to me:
> Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>
 
Thanks
Reviewed-by: Harini Katakam <harini.katakam@....com>

Regards,
Harini