netdev - Re: [PATCH net-next] net: page_pool: add pages and released

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230414184653.21b4303d@kernel.org>
Date:   Fri, 14 Apr 2023 18:46:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, hawk@...nel.org,
        ilias.apalodimas@...aro.org, davem@...emloft.net,
        edumazet@...gle.com, pabeni@...hat.com,
        lorenzo.bianconi@...hat.com, jdamato@...tly.com
Subject: Re: [PATCH net-next] net: page_pool: add pages and released_pages
 counters

On Thu, 13 Apr 2023 23:46:03 +0200 Lorenzo Bianconi wrote:
> @@ -411,6 +417,7 @@ static struct page *__page_pool_alloc_pages_slow(struct page_pool *pool,
>  		pool->pages_state_hold_cnt++;
>  		trace_page_pool_state_hold(pool, page,
>  					   pool->pages_state_hold_cnt);
> +		alloc_stat_inc(pool, pages);
>  	}
>  
>  	/* Return last page */

What about high order? If we use bulk API for high order one day, 
will @slow_high_order not count calls like @slow does? So we should
bump the new counter for high order, too.

Which makes it very similar to pages_state_hold_cnt, just 64bit...