netdev - Re: [PATCH v9 3/3] net/handshake: Add Kunit tests for the handshake consumer API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDocVvsqKJ57c1Tk@manet.1015granger.net>
Date:   Fri, 14 Apr 2023 23:39:02 -0400
From:   Chuck Lever <cel@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     pabeni@...hat.com, edumazet@...gle.com, netdev@...r.kernel.org,
        kernel-tls-handshake@...ts.linux.dev
Subject: Re: [PATCH v9 3/3] net/handshake: Add Kunit tests for the handshake
 consumer API

On Fri, Apr 14, 2023 at 07:15:42PM -0700, Jakub Kicinski wrote:
> On Fri, 14 Apr 2023 22:06:59 -0400 Chuck Lever wrote:
> > On Fri, Apr 14, 2023 at 06:31:13PM -0700, Jakub Kicinski wrote:
> > > We're getting:
> > > 
> > > net/handshake/.kunitconfig: warning: ignored by one of the .gitignore files
> > > 
> > > during allmodconfig build, any idea where that's coming from?  
> > 
> > As far as I know, all of the .kunitconfig files in the kernel tree
> > are marked "ignored". I'm not sure why, nor if it's a significant
> > problem.
> 
> To be clear - no idea what the problem is but I don't think all
> of them are:
> 
> $ echo a > fs/fat/.kunitconfig
> $ echo b > mm/kfence/.kunitconfig
> $ echo c > net/sunrpc/.kunitconfig
> $ git status
> Changes not staged for commit:
>   (use "git add <file>..." to update what will be committed)
>   (use "git restore <file>..." to discard changes in working directory)
> 	modified:   fs/fat/.kunitconfig
> 	modified:   mm/kfence/.kunitconfig
> 	modified:   net/sunrpc/.kunitconfig

The "ignored" list I got from the bot yesterday indeed included
net/sunrpc/.kunitconfig as well as net/handshake/.kunitconfig, but
git doesn't actually seem to ignore changes to these files, as you
demonstrate here.

I don't see a specific pattern in the kernel's .gitconfig that
would exclude .kunitconfig files from change tracking.

I can see where this warning might introduce false negative build
results, but so far I haven't heard that particular complaint about
net/sunrpc/.kunitconfig.

Again, I wasn't sure if this was a significant problem or simply
noise, so I haven't chased it. If someone on-list has insight,
please speak up. I can try to have a look at it tomorrow.