netdev - Re: [PATCH net-next] net/sched: clear actions pointer in miss cookie init fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Apr 2023 14:45:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pedro Tammela <pctammela@...atatu.com>, netdev@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        marcelo.leitner@...il.com, paulb@...dia.com,
        simon.horman@...igine.com, Pedro Tammela <pctammela@...atatu.com>,
        Palash Oswal <oswalpalash@...il.com>
Subject: Re: [PATCH net-next] net/sched: clear actions pointer in miss cookie
 init fail

Hi Pedro,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Pedro-Tammela/net-sched-clear-actions-pointer-in-miss-cookie-init-fail/20230415-054434
patch link:    https://lore.kernel.org/r/20230414214317.227128-1-pctammela%40mojatatu.com
patch subject: [PATCH net-next] net/sched: clear actions pointer in miss cookie init fail
config: riscv-defconfig (https://download.01.org/0day-ci/archive/20230415/202304151408.D1kAjGwb-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/0a51c6cee30eab6b3023dbcd65899511f14cd8e8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Pedro-Tammela/net-sched-clear-actions-pointer-in-miss-cookie-init-fail/20230415-054434
        git checkout 0a51c6cee30eab6b3023dbcd65899511f14cd8e8
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/sched/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304151408.D1kAjGwb-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/sched/cls_api.c: In function 'tcf_exts_init_ex':
>> net/sched/cls_api.c:3238:15: error: 'struct tcf_exts' has no member named 'actions'; did you mean 'action'?
    3238 |         exts->actions = NULL;
         |               ^~~~~~~
         |               action


vim +3238 net/sched/cls_api.c

  3223	
  3224		exts->action = action;
  3225		exts->police = police;
  3226	
  3227		if (!use_action_miss)
  3228			return 0;
  3229	
  3230		err = tcf_exts_miss_cookie_base_alloc(exts, tp, handle);
  3231		if (err)
  3232			goto err_miss_alloc;
  3233	
  3234		return 0;
  3235	
  3236	err_miss_alloc:
  3237		tcf_exts_destroy(exts);
> 3238		exts->actions = NULL;
  3239		return err;
  3240	}
  3241	EXPORT_SYMBOL(tcf_exts_init_ex);
  3242	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests