netdev - Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230415101234.rmo3b27iv3p5o42l@skbuf>
Date:   Sat, 15 Apr 2023 13:12:34 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Daniel Golle <daniel@...rotopia.org>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run
 twice

On Sat, Apr 15, 2023 at 01:41:07AM +0300, Arınç ÜNAL wrote:
> I moved enabling the regulators from mt7530_setup() to mt7530_probe().
> Enabling the regulators there ends up with exception warnings on the
> first time.

Have you read what the WARN_ON() in _regulator_put() has to say?

	/* Docs say you must disable before calling regulator_put() */
	WARN_ON(regulator->enable_count);

If you call regulator_enable() during probe, do you also call
regulator_disable() during the probe error path?