netdev - Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230415134604.2mw3iodnrd2savs3@skbuf>
Date:   Sat, 15 Apr 2023 16:46:04 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Daniel Golle <daniel@...rotopia.org>,
        Frank Wunderlich <frank-w@...lic-files.de>,
        netdev <netdev@...r.kernel.org>, erkin.bozoglu@...ont.com,
        Thibaut <hacks@...shdirt.org>
Subject: Re: mt7530: dsa_switch_parse_of() fails, causes probe code to run
 twice

On Sat, Apr 15, 2023 at 04:40:19PM +0300, Arınç ÜNAL wrote:
> My wording was not great there. What I meant is that PHY muxing will be
> configured before dsa_register_switch() is run.

And we're back to the discussion from the thread "Move MT7530 phy muxing
from DSA to PHY driver". What if someone decides that they don't need
the switch driver - can they disable it? No.

Your thoughts are stopping mid way. If you think that PHY muxing should
work without registering the DSA switch, then it doesn't belong in the
DSA driver, plain and simple. No "yeah, but I can move it here, and it
could kinda work, as a side effect of a driver failing to probe, or
probing successfully but not registering with the subsystems for its
primary purpose, or ...".