netdev - [PATCH 0/2] brcmfmac: Demote some kernel errors to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230416-brcmfmac-noise-v1-0-f0624e408761@marcan.st>
Date:   Sun, 16 Apr 2023 21:42:16 +0900
From:   Hector Martin <marcan@...can.st>
To:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "John W. Linville" <linville@...driver.com>
Cc:     linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
        Hector Martin <marcan@...can.st>, stable@...r.kernel.org
Subject: [PATCH 0/2] brcmfmac: Demote some kernel errors to info

brcmfmac has some messages that are KERN_ERR even though they are
harmless. This is spooking and confusing people, because they end up
being the *only* kernel messages on their boot console with common
error-only printk levels (at least on Apple Macs).

Then, when their system does not boot to a GUI for some other reason,
the brcmfmac errors are the only thing on their TTY (which also does
not show a login prompt on tty1 in typical systemd setups) and they are
thoroughly confused into believing their problem has something to do
with brcmfmac.

Seriously, I've had 10 or so people mention this by now, and multiple
confused Reddit threads about it. Let's fix it.

Signed-off-by: Hector Martin <marcan@...can.st>
---
Hector Martin (2):
      wifi: brcmfmac: Demote vendor-specific attach/detach messages to info
      wifi: brcmfmac: Demote p2p unknown frame error to info (once)

 drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c | 4 ++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 ++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c      | 4 ++--
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)
---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230416-brcmfmac-noise-2bae83836f2d

Best regards,
-- 
Hector Martin <marcan@...can.st>