netdev - Re: [PATCH net-next v2 2/3] r8169: use new macro netif_subqueue_maybe_stop in rtl8169_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230416132401.GE15386@unreal>
Date:   Sun, 16 Apr 2023 16:24:01 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/3] r8169: use new macro
 netif_subqueue_maybe_stop in rtl8169_start_xmit

On Sun, Apr 16, 2023 at 01:33:11PM +0200, Heiner Kallweit wrote:
> On 16.04.2023 12:20, Leon Romanovsky wrote:
> > On Sat, Apr 15, 2023 at 09:22:11AM +0200, Heiner Kallweit wrote:
> >> Use new net core macro netif_subqueue_maybe_stop in the start_xmit path
> >> to simplify the code. Whilst at it, set the tx queue start threshold to
> >> twice the stop threshold. Before values were the same, resulting in
> >> stopping/starting the queue more often than needed.
> >>
> >> v2:
> >> - ring doorbell if queue was stopped
> > 
> > Please put changelog under "---" markup, below tags section.
> > 
> I know that this would be the standard. IIRC Dave once requested to
> make the change log part of the commit message.

I can imagine how it was useful before lore.kernel.org appeared.

Thanks

> 
> > Thanks
> > 
>