netdev - [PATCH] wifi: ath12k: fix missing unwind goto in `ath12k_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230417115921.176229-1-lnk_01@hust.edu.cn>
Date:   Mon, 17 Apr 2023 11:59:21 +0000
From:   Li Ningke <lnk_01@...t.edu.cn>
To:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>,
        Jeff Johnson <quic_jjohnson@...cinc.com>,
        Karthikeyan Periyasamy <quic_periyasa@...cinc.com>,
        Carl Huang <quic_cjhuang@...cinc.com>,
        P Praneesh <quic_ppranees@...cinc.com>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Li Ningke <lnk_01@...t.edu.cn>,
        Dongliang Mu <dzm91@...t.edu.cn>,
        Kalle Valo <quic_kvalo@...cinc.com>,
        Bhagavathi Perumal S <quic_bperumal@...cinc.com>,
        Baochen Qiang <quic_bqiang@...cinc.com>,
        Balamurugan Selvarajan <quic_bselvara@...cinc.com>,
        ath12k@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] wifi: ath12k: fix missing unwind goto in `ath12k_pci_probe`

Smatch complains that
drivers/net/wireless/ath/ath12k/pci.c:1198 ath12k_pci_probe() warn: 
missing unwind goto?

In order to release the allocated resources before returning an
error, the statement that directly returns the error is changed
to a goto statement that first releases the resources in the error
handling section.

Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices")
Signed-off-by: Li Ningke <lnk_01@...t.edu.cn>
Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
---
The issue is found by static analysis and the patch remains untested.
---
 drivers/net/wireless/ath/ath12k/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath12k/pci.c b/drivers/net/wireless/ath/ath12k/pci.c
index ae7f6083c9fc..f523aa15885f 100644
--- a/drivers/net/wireless/ath/ath12k/pci.c
+++ b/drivers/net/wireless/ath/ath12k/pci.c
@@ -1195,7 +1195,8 @@ static int ath12k_pci_probe(struct pci_dev *pdev,
 			dev_err(&pdev->dev,
 				"Unknown hardware version found for QCN9274: 0x%x\n",
 				soc_hw_version_major);
-			return -EOPNOTSUPP;
+			ret = -EOPNOTSUPP;
+			goto err_pci_free_region;
 		}
 		break;
 	case WCN7850_DEVICE_ID:
-- 
2.34.1