netdev - Re: [PATCH net-next] xsk: introduce xsk_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230417115610.7763a87c@kernel.org>
Date:   Mon, 17 Apr 2023 11:56:10 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
Cc:     Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
        Björn Töpel <bjorn@...nel.org>,
        Magnus Karlsson <magnus.karlsson@...el.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        Jonathan Lemon <jonathan.lemon@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        Jason Wang <jasowang@...hat.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH net-next] xsk: introduce xsk_dma_ops

On Mon, 17 Apr 2023 13:58:01 +0800 Xuan Zhuo wrote:
> On Sun, 16 Apr 2023 21:24:32 -0700, Christoph Hellwig <hch@...radead.org> wrote:
> > On Mon, Apr 17, 2023 at 11:27:50AM +0800, Xuan Zhuo wrote:  
> > > The purpose of this patch is to allow driver pass the own dma_ops to
> > > xsk.  
> >
> > Drivers have no business passing around dma_ops, or even knowing about
> > them.  
> 
> May misunderstand, here the "dma_ops" is not the "dma_ops" of DMA API.
> 
> I mean the callbacks for xsk to do dma.
> 
> Maybe, I should rename it in the next version.

Would you mind explaining this a bit more to folks like me who are not
familiar with VirtIO?  DMA API is supposed to hide the DMA mapping
details from the stack, why is it not sufficient here.