netdev - Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document endian check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Apr 2023 09:19:58 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Álvaro Fernández Rojas <noltari@...il.com>,
        f.fainelli@...il.com, jonas.gorski@...il.com, nbd@....name,
        toke@...e.dk, kvalo@...nel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        chunkeey@...il.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: net: wireless: ath9k: document endian
 check

On 17/04/2023 07:35, Álvaro Fernández Rojas wrote:
> Document new endian check flag to allow checking the endianness of EEPROM and
> swap its values if needed.
> 
> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed the lists so this won't be tested. Resend following Linux
kernel submission process.


> ---
>  .../devicetree/bindings/net/wireless/qca,ath9k.yaml          | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> index 0e5412cff2bc..ff9ca5e3674b 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> @@ -44,6 +44,11 @@ properties:
>  
>    ieee80211-freq-limit: true
>  
> +  qca,endian-check:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Indicates that the EEPROM endianness should be checked

Does not look like hardware property. Do not instruct what driver should
or should not do. It's not the purpose of DT.


Best regards,
Krzysztof