netdev - Re: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach messages to info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b2e7bb9-3681-0265-01bc-e7abdd0d08b8@marcan.st>
Date:   Mon, 17 Apr 2023 16:54:33 +0900
From:   Hector Martin <marcan@...can.st>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Arend van Spriel <aspriel@...il.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "John W. Linville" <linville@...driver.com>,
        linux-wireless@...r.kernel.org,
        brcm80211-dev-list.pdl@...adcom.com,
        SHA-cyfmac-dev-list@...ineon.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, asahi@...ts.linux.dev,
        stable@...r.kernel.org
Subject: Re: [PATCH 1/2] wifi: brcmfmac: Demote vendor-specific attach/detach
 messages to info

On 16/04/2023 21.46, Greg KH wrote:
> On Sun, Apr 16, 2023 at 09:42:17PM +0900, Hector Martin wrote:
>> People are getting spooked by brcmfmac errors on their boot console.
>> There's no reason for these messages to be errors.
>>
>> Cc: stable@...r.kernel.org
>> Fixes: d6a5c562214f ("wifi: brcmfmac: add support for vendor-specific firmware api")
>> Signed-off-by: Hector Martin <marcan@...can.st>
>> ---
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c | 4 ++--
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 ++--
>>  drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
>>  3 files changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> index ac3a36fa3640..c83bc435b257 100644
>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/bca/core.c
>> @@ -12,13 +12,13 @@
>>  
>>  static int brcmf_bca_attach(struct brcmf_pub *drvr)
>>  {
>> -	pr_err("%s: executing\n", __func__);
>> +	pr_info("%s: executing\n", __func__);
> 
> Why are these here at all?  Please just remove these entirely, you can
> get this information normally with ftrace.
> 
> Or, just delete these functions, why have empty ones at all?

This is a new WIP code path that Arend introduced which currently
deliberately does nothing (but is intended to hold firmware vendor
specific init in the future). So we can just drop the messages, but I
don't think we want to remove the code entirely.

- Hector