netdev - Re: [PATCH net-next v1 2/2] net: dsa: microchip: Add partial ACL support for ksz9477 switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230417101209.m5fhc7njeeomljkf@skbuf>
Date:   Mon, 17 Apr 2023 13:12:09 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        kernel@...gutronix.de, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next v1 2/2] net: dsa: microchip: Add partial ACL
 support for ksz9477 switches

On Mon, Apr 17, 2023 at 06:57:10AM +0200, Oleksij Rempel wrote:
> > On Tue, Apr 11, 2023 at 07:24:55PM +0200, Oleksij Rempel wrote:
> > > The ACL also implements a count function, generating an interrupt
> > > instead of a forwarding action. It can be used as a watchdog timer or an
> > > event counter.
> > 
> > Is the interrupt handled here? I didn't see cls_flower_stats().
> 
> No, it is not implemented in this patch. It is generic description of things
> ACL should be able to do. Is it confusing? Should I remove it?

No, it's confusing that the ACL statistics are not reported even though
it's mentioned that it's possible...

> > Have you considered the "skbedit priority" action as opposed to hw_tc?
> 
> I had already thought of that, but since bridging is offloaded in the HW
> no skbs are involved, i thought it will be confusing. Since tc-flower seems to
> already support hw_tc remapping, I decided to use it. I hope it will not harm,
> to use it for now as mandatory option and make it optional later if other
> actions are added, including skbedit.

Well, skbedit is offloadable, so in that sense, its behavior is defined
even when no skbs are involved. OTOH, skbedit also has a software data
path (sets skb->priority), as opposed to hw_tc, which last time I checked,
did not.