netdev - Re: [PATCH next-next v3 0/3] extend drop reasons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cecbd933afefedf641be2e55540f2f501a7278de.camel@sipsolutions.net>
Date:   Tue, 18 Apr 2023 11:39:25 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH next-next v3 0/3] extend drop reasons

On Fri, 2023-04-14 at 19:20 -0700, Jakub Kicinski wrote:
> On Fri, 14 Apr 2023 18:22:19 -0700 Jakub Kicinski wrote:
> > FWIW:
> > 
> > Acked-by: Jakub Kicinski <kuba@...nel.org>
> 
> I take that back :)
> 
> This:
> 
> > +	/** @SKB_DROP_REASON_SUBSYS_MASK: subsystem mask in drop reasons,
> > +	 * see &enum skb_drop_reason_subsys
> > +	 */
> 
> is not valid kdoc, confusingly.
> If it's longer than one line, the /** has to be on an otherwise empty line.

Meh.

> Run the new files thru ./scripts/kernel-doc -none, perhaps.

Yeah, I can even run the whole nipa thing, it just seemed obvious enough
and our automation isn't quite working yet so it's another manual
step... Sorry about that.

johannes


PS: you're not using the docker container I guess:
https://patchwork.hopto.org/static/nipa/739889/13211664/checkpatch/stderr
(I fixed that in the dockerfile I think?)