netdev - Re: [PATCH 3/6] crypto: hash - Add crypto_clone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZD6NGchekDuquh1s@corigine.com>
Date:   Tue, 18 Apr 2023 14:29:13 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Dmitry Safonov <dima@...sta.com>,
        Andy Lutomirski <luto@...capital.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bob Gilligan <gilligan@...sta.com>,
        Dan Carpenter <error27@...il.com>,
        David Laight <David.Laight@...lab.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Eric Biggers <ebiggers@...nel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Francesco Ruggeri <fruggeri05@...il.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ivan Delalande <colona@...sta.com>,
        Leonard Crestez <cdleonard@...il.com>,
        Salam Noureddine <noureddine@...sta.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH 3/6] crypto: hash - Add crypto_clone_ahash/shash

On Thu, Apr 13, 2023 at 02:24:19PM +0800, Herbert Xu wrote:
> This patch adds the helpers crypto_clone_ahash and crypto_clone_shash.
> They are the hash-specific counterparts of crypto_clone_tfm.
> 
> This allows code paths that cannot otherwise allocate a hash tfm
> object to do so.  Once a new tfm has been obtained its key could
> then be changed without impacting other users.
> 
> Note that only algorithms that implement clone_tfm can be cloned.
> However, all keyless hashes can be cloned by simply reusing the
> tfm object.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Reviewed-by: Simon Horman <simon.horman@...igine.com>