netdev - Re: [PATCH net] net/sched: sch_fq: fix integer overflow of "credit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKa-r6s2Qn_O+c1_gBT=+5ndHcL92FspSogo22ws3-iCqUSjEw@mail.gmail.com>
Date:   Tue, 18 Apr 2023 17:03:47 +0200
From:   Davide Caratti <dcaratti@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Christoph Paasch <cpaasch@...le.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: sch_fq: fix integer overflow of "credit"

hello,

On Tue, Apr 18, 2023 at 4:43 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 18 Apr 2023 12:26:13 +0200 Eric Dumazet wrote:
> > > Please set the right policy in fq_policy[] instead.
> >
> > Not sure these policies are available for old kernels (sch_fq was
> > added in linux-3.12) ?

[...]

> Good point, Davide, once the policy based fix hits the trees please
> send this version of the fix to stable@ for 5.4 and older stable trees.

Sure, I will do that. And thanks for the review! :)
--
davide