| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Apr 2023 09:30:09 -0700
From: Shannon Nelson <shannon.nelson@....com>
To: kernel test robot <lkp@...el.com>, brett.creeley@....com,
davem@...emloft.net, netdev@...r.kernel.org, kuba@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, drivers@...sando.io,
leon@...nel.org, jiri@...nulli.us, simon.horman@...igine.com
Subject: Re: [PATCH v10 net-next 14/14] pds_core: Kconfig and pds_core.rst
On 4/17/23 8:56 PM, kernel test robot wrote:
> Hi Shannon,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on net-next/main]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Shannon-Nelson/pds_core-initial-framework-for-pds_core-PF-driver/20230418-083612
> patch link: https://lore.kernel.org/r/20230418003228.28234-15-shannon.nelson%40amd.com
> patch subject: [PATCH v10 net-next 14/14] pds_core: Kconfig and pds_core.rst
> config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230418/202304181137.WaZTYyAa-lkp@intel.com/config)
> compiler: sparc64-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/98284802ba918b756684dcf00cfa88bbab5cb498
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Shannon-Nelson/pds_core-initial-framework-for-pds_core-PF-driver/20230418-083612
> git checkout 98284802ba918b756684dcf00cfa88bbab5cb498
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash drivers/net/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@...el.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202304181137.WaZTYyAa-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> drivers/net/ethernet/amd/pds_core/auxbus.c: In function 'pds_client_register':
>>> drivers/net/ethernet/amd/pds_core/auxbus.c:30:9: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
> 30 | strncpy(cmd.client_reg.devname, devname,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 31 | sizeof(cmd.client_reg.devname));
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Yes, this should be a strscpy(), not strncpy(). As much as I'd like to
fix this one thing Right Now, I'll wait another day before I repost the
full patchset for one little tweak.
sln
>
>
> vim +/strncpy +30 drivers/net/ethernet/amd/pds_core/auxbus.c
>
> de85ef78c6b4f6 Shannon Nelson 2023-04-17 8
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 9 /**
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 10 * pds_client_register - Link the client to the firmware
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 11 * @pf_pdev: ptr to the PF driver struct
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 12 * @devname: name that includes service into, e.g. pds_core.vDPA
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 13 *
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 14 * Return: 0 on success, or
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 15 * negative for error
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 16 */
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 17 int pds_client_register(struct pci_dev *pf_pdev, char *devname)
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 18 {
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 19 union pds_core_adminq_comp comp = {};
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 20 union pds_core_adminq_cmd cmd = {};
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 21 struct pdsc *pf;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 22 int err;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 23 u16 ci;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 24
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 25 pf = pci_get_drvdata(pf_pdev);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 26 if (pf->state)
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 27 return -ENXIO;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 28
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 29 cmd.client_reg.opcode = PDS_AQ_CMD_CLIENT_REG;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 @30 strncpy(cmd.client_reg.devname, devname,
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 31 sizeof(cmd.client_reg.devname));
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 32
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 33 err = pdsc_adminq_post(pf, &cmd, &comp, false);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 34 if (err) {
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 35 dev_info(pf->dev, "register dev_name %s with DSC failed, status %d: %pe\n",
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 36 devname, comp.status, ERR_PTR(err));
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 37 return err;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 38 }
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 39
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 40 ci = le16_to_cpu(comp.client_reg.client_id);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 41 if (!ci) {
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 42 dev_err(pf->dev, "%s: device returned null client_id\n",
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 43 __func__);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 44 return -EIO;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 45 }
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 46
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 47 dev_dbg(pf->dev, "%s: device returned client_id %d for %s\n",
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 48 __func__, ci, devname);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 49
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 50 return ci;
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 51 }
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 52 EXPORT_SYMBOL_GPL(pds_client_register);
> 283e6c9307d7f4 Shannon Nelson 2023-04-17 53
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests
Powered by blists - more mailing lists