netdev - Re: [PATCH] net: amd: Fix link leak when verifying config failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230418155215.24e7e140@kernel.org>
Date:   Tue, 18 Apr 2023 15:52:15 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Gencen Gan <gangecen@...t.edu.cn>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: amd: Fix link leak when verifying config failed

On Mon, 17 Apr 2023 22:47:50 +0800 Gencen Gan wrote:
> From: Gecen Gan <gangecen@...t.edu.cn>
> 
> After failing to verify configuration, it returns directly without 
> releasing link, which may cause memory leak.
> 
> Signed-off-by: Gecen Gan <gangecen@...t.edu.cn>
> ---
>  drivers/net/ethernet/amd/nmclan_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/nmclan_cs.c b/drivers/net/ethernet/amd/nmclan_cs.c
> index 823a329a921f..0dd391c84c13 100644
> --- a/drivers/net/ethernet/amd/nmclan_cs.c
> +++ b/drivers/net/ethernet/amd/nmclan_cs.c
> @@ -651,7 +651,7 @@ static int nmclan_config(struct pcmcia_device *link)
>   } else {
>       pr_notice("mace id not found: %x %x should be 0x40 0x?9\n",
>  	  sig[0], sig[1]);
> -     return -ENODEV;
> +     goto failed;
>     }
>   }

The patch looks whitespace-damaged, it doesn't apply cleanly.
AFAICT there is one space missing in the indentation.
Probably your email server is doing something funny to it.

--
pw-bot: cr