netdev - Re: [PATCH net] net/sched: sch_fq: fix integer overflow of "credit"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Apr 2023 19:30:31 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Eric Dumazet <edumazet@...gle.com>,
        Christoph Paasch <cpaasch@...le.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net/sched: sch_fq: fix integer overflow of "credit"

On Mon, 17 Apr 2023 13:02:40 +0200 Davide Caratti wrote:
> +		u32 initial_quantum = nla_get_u32(tb[TCA_FQ_INITIAL_QUANTUM]);
> +
> +		if (initial_quantum <= INT_MAX) {
> +			q->initial_quantum = initial_quantum;
> +		} else {
> +			NL_SET_ERR_MSG_MOD(extack, "invalid initial quantum");
> +			err = -EINVAL;
> +		}

Please set the right policy in fq_policy[] instead.