netdev - Re: [net PATCH v3 03/10] octeontx2-af: Fix depth of cam and mem table.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZD+6SOCYdXNG02s5@corigine.com>
Date:   Wed, 19 Apr 2023 11:54:16 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Sai Krishna <saikrishnag@...vell.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, leon@...nel.org,
        sgoutham@...vell.com, gakula@...vell.com, lcherian@...vell.com,
        jerinj@...vell.com, hkelam@...vell.com, sbhatta@...vell.com,
        Ratheesh Kannoth <rkannoth@...vell.com>
Subject: Re: [net PATCH v3 03/10] octeontx2-af: Fix depth of cam and mem
 table.

On Wed, Apr 19, 2023 at 11:50:11AM +0530, Sai Krishna wrote:
> From: Ratheesh Kannoth <rkannoth@...vell.com>
> 
> Depth of CAM and MEM tables were wrongly configured. Fixed
> the same in NPC module.
> 
> Fixes: b747923afff8 ("octeontx2-af: Exact match support")
> Signed-off-by: Ratheesh Kannoth <rkannoth@...vell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@...vell.com>
> Signed-off-by: Sai Krishna <saikrishnag@...vell.com>

If there is an issue that this resolves, especially
something user-visible, it might be useful to explain what it
is - e.g. before and after. Likewise for a number of other patches
in the series.

But that notwithstanding, this looks good,
with the caveat that I can't verify that the change matches the HW.

Reviewed-by: Simon Horman <simon.horman@...igine.com>