netdev - Re: net: mvpp2: tai: add extts support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e62fb37d7118b5b1de68d0d2d961a6408c0f299.camel@siklu.com>
Date:   Wed, 19 Apr 2023 13:30:18 +0000
From:   Shmuel Hazan <shmuel.h@...lu.com>
To:     "mw@...ihalf.com" <mw@...ihalf.com>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "horatiu.vultur@...rochip.com" <horatiu.vultur@...rochip.com>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: Re: net: mvpp2: tai: add extts support

On Wed, 2023-04-19 at 03:20 +0200, Marcin Wojtas wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments.
> 
> 
> Hi Shmuel,
> 
> pon., 17 kwi 2023 o 18:03 Shmuel Hazan <shmuel.h@...lu.com> napisał(a):
> > 
> > This patch series adds support for PTP event capture on the Aramda
> > 80x0/70x0. This feature is mainly used by tools linux ts2phc(3) in order
> > to synchronize a timestamping unit (like the mvpp2's TAI) and a system
> > DPLL on the same PCB.
> > 
> > The patch series includes 3 patches: the second one implements the
> > actual extts function.
> > 
> > 
> 
> Thank you for the patches. For v3, could you please generate a cover
> letter and properly number all the patches? Please also list the
> changes between the revisions.


Hi Marcin, 

No problem. Thanks. 

> 
> What setup/tooling is required to verify the changes?

In to test it, you'll need an Armada 80x0/70x0-based PCB, with a PPS
input that goes to a PTP_PULSE pin and a GPIO pin. Then, define the
gpio pin as a pps-gpio and run ts4phc (from linuxptp) as follow:

ts2phc -s /dev/ppsX -c /dev/ptpY

Replace X with the relevant pps device ID, and Y with the ptp device
that PTP_PULSE is connected to (CP0 or CP1). 

If anything goes well, you should see that ts2phc gets to about ~0-1
ns of offset between the clocks.

> 
> Best regards,
> Marcin