netdev - Re: [PATCH net-next] net: libwx: fix memory leak in wx_setup_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEAGm73nAuB8aHnN@corigine.com>
Date:   Wed, 19 Apr 2023 17:19:55 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, jiawenwu@...stnetic.com,
        mengyuanlou@...-swift.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        yang.lee@...ux.alibaba.com, error27@...il.com
Subject: Re: [PATCH net-next] net: libwx: fix memory leak in
 wx_setup_rx_resources

On Tue, Apr 18, 2023 at 02:54:50PM +0800, Zhengchao Shao wrote:
> When wx_alloc_page_pool() failed in wx_setup_rx_resources(), it doesn't
> release DMA buffer. Add dma_free_coherent() in the error path to release
> the DMA buffer.
> 
> Fixes: 850b971110b2 ("net: libwx: Allocate Rx and Tx resources")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>

Reviewed-by: Simon Horman <simon.horman@...igine.com>