netdev - Re: [PATCH] net: hyperv: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEBANRDxW+yod7yA@corigine.com>
Date:   Wed, 19 Apr 2023 21:25:41 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Saurabh Sengar <ssengar@...ux.microsoft.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Arnd Bergmann <arnd@...db.de>, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: hyperv: select CONFIG_NLS for mac address setting

On Mon, Apr 17, 2023 at 10:55:48PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A rare randconfig build error happens when this driver is
> enabled, but nothing else enables NLS support:
> 
> x86_64-linux-ld: drivers/net/hyperv/rndis_filter.o: in function `rndis_filter_set_device_mac':
> rndis_filter.c:(.text+0x1536): undefined reference to `utf8s_to_utf16s'
> 
> This is normally selected by PCI, USB, ACPI, or common file systems.
> Since the dependency on ACPI is now gone, NLS has to be selected
> here directly.
> 
> Fixes: 38299f300c12 ("Driver: VMBus: Add Devicetree support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Simon Horman <simon.horman@...igine.com>