netdev - Re: [PATCH net-next] gve: Add modify ring size support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230419154850.5fec4c1d@kernel.org>
Date:   Wed, 19 Apr 2023 15:48:50 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Alex Berliner <alexberliner@...gle.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        Jeroen de Borst <jeroendb@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] gve: Add modify ring size support

On Tue, 18 Apr 2023 22:13:13 +0000 Alex Berliner wrote:
> +		err = gve_close(priv->dev);
> +		if (err)
> +			return err;
> +		priv->tx_desc_cnt = new_tx_desc_cnt;
> +		priv->rx_desc_cnt = new_rx_desc_cnt;
> +
> +		err = gve_open(priv->dev);
> +		if (err)
> +			goto err;

please don't close / open. if the machine is low on memory it will 
fall off the network. I think I had a similar complaint about xdp
patches for gve, it'd be great if people working on gve within google
talked to each other.