netdev - Re: [PATCHv5 net-next] bonding: add software tx timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZD9pbffw3s1HVwvE@Laptop-X1>
Date:   Wed, 19 Apr 2023 12:09:17 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Liang Li <liali@...hat.com>,
        Simon Horman <simon.horman@...igine.com>,
        Miroslav Lichvar <mlichvar@...hat.com>
Subject: Re: [PATCHv5 net-next] bonding: add software tx timestamping support

On Tue, Apr 18, 2023 at 08:50:23PM -0700, Jakub Kicinski wrote:
> On Tue, 18 Apr 2023 11:48:41 +0800 Hangbin Liu wrote:
> > Currently, bonding only obtain the timestamp (ts) information of
> > the active slave, which is available only for modes 1, 5, and 6.
> > For other modes, bonding only has software rx timestamping support.
> > 
> > However, some users who use modes such as LACP also want tx timestamp
> > support. To address this issue, let's check the ts information of each
> > slave. If all slaves support tx timestamping, we can enable tx
> > timestamping support for the bond.
> > 
> > Add a note that the get_ts_info may be called with RCU, or rtnl or
> > reference on the device in ethtool.h>
> > 
> > Suggested-by: Miroslav Lichvar <mlichvar@...hat.com>
> > Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> > ---
> > v5: remove ASSERT_RTNL since bond_ethtool_get_ts_info could be called
> >     without RTNL. Update ethtool kdoc.
> 
> I'll apply Jay's ack from v4 since these are not substantial changes.
> Thanks!

Sorry, not sure if I missed something. bond_ethtool_get_ts_info() could be
called without RTNL. And we have ASSERT_RTNL() in v4.

Thanks
Hangbin