netdev - Re: [PATCH net v2] nfp: correct number of MSI vectors requests returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEDo0RrtX5okUTN2@corigine.com>
Date:   Thu, 20 Apr 2023 09:25:05 +0200
From:   Simon Horman <simon.horman@...igine.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     David Laight <David.Laight@...lab.com>,
        'Louis Peens' <louis.peens@...igine.com>,
        David Miller <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Leon Romanovsky <leon@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "oss-drivers@...igine.com" <oss-drivers@...igine.com>
Subject: Re: [PATCH net v2] nfp: correct number of MSI vectors requests
 returned

On Wed, Apr 19, 2023 at 06:34:09PM -0700, Jakub Kicinski wrote:
> On Wed, 19 Apr 2023 15:37:57 +0000 David Laight wrote:
> > > Before the referenced commit, if fewer interrupts are supported by
> > > hardware than requested, then pci_msix_vec_count() returned the
> > > former. However, after the referenced commit, an error is returned
> > > for this condition. This causes a regression in the NFP driver
> > > preventing probe from completing.  
> > 
> > I believe the relevant change to the msix vector allocation
> > function has been reverted.
> > (Or at least, the over-zealous check of nvec removed.)
> > 
> > So this change to bound the number of interrupts
> > isn't needed.
> 
> Great, thanks, I was about to ask!

Likewise, thanks.
We'll look into this.