netdev - Re: [PATCH net-next 2/6] sctp: delete the nested flexible array skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Apr 2023 18:20:01 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Xin Long <lucien.xin@...il.com>,
        network dev <netdev@...r.kernel.org>,
        linux-sctp@...r.kernel.org, davem@...emloft.net,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Subject: Re: [PATCH net-next 2/6] sctp: delete the nested flexible array
 skip

On Wed, 19 Apr 2023 08:31:25 -0700 Stephen Hemminger wrote:
> >  struct sctp_fwdtsn_hdr {
> >  	__be32 new_cum_tsn;
> > -	struct sctp_fwdtsn_skip skip[];
> > +	/* struct sctp_fwdtsn_skip skip[]; */
> >  };
> >    
> 
> Why leave the old structure in comments.
> Remove unused code and data structures please.

Did you see the note in the cover letter?
Is there any reason why this is not an acceptable way of documenting
what follows?