netdev - Re: [PATCH net-next] net: skbuff: update and rename __kfree_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <862a1a97-22a7-bbea-486e-2171f47a2148@intel.com>
Date:   Thu, 20 Apr 2023 17:06:07 +0200
From:   Alexander Lobakin <aleksander.lobakin@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <edumazet@...gle.com>, <pabeni@...hat.com>
Subject: Re: [PATCH net-next] net: skbuff: update and rename
 __kfree_skb_defer()

From: Jakub Kicinski <kuba@...nel.org>
Date: Wed, 19 Apr 2023 19:00:05 -0700

> __kfree_skb_defer() uses the old naming where "defer" meant
> slab bulk free/alloc APIs. In the meantime we also made
> __kfree_skb_defer() feed the per-NAPI skb cache, which
> implies bulk APIs. So take away the 'defer' and add 'napi'.
> 
> While at it add a drop reason. This only matters on the
> tx_action path, if the skb has a frag_list. But getting
> rid of a SKB_DROP_REASON_NOT_SPECIFIED seems like a net
> benefit so why not.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

[...]

Thanks,
Olek