netdev - Re: [PATCH net] net/mlx5: Fix management PF condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHC9VhQza6Wj+mEf-VDZX3f2em94R=CQm=ghNL55JkOSjR6H8Q@mail.gmail.com>
Date:   Thu, 20 Apr 2023 13:22:31 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>, shayd@...dia.com
Subject: Re: [PATCH net] net/mlx5: Fix management PF condition

On Wed, Apr 19, 2023 at 11:57 PM Saeed Mahameed <saeed@...nel.org> wrote:
> From: Saeed Mahameed <saeedm@...dia.com>
>
> Paul reports that it causes a regression with IB on CX4 and FW 12.18.1000
>
> Management PF capabilities can be set on old FW due to the use of old
> reserved bits, to avoid such issues, explicitly check for new Bluefield
> devices as well as for management PF capabilities, since management PF
> is a minimal eth device that is meant to communicate between the ARM cores
> of the Bluefield chip and the BMC node.
>
> This should Fix the issue since Bluefield devices have relatively new
> firmwares that don't have this bug.
>
> Fixes: fe998a3c77b9 ("net/mlx5: Enable management PF initialization")
> Reported-by: Paul Moore <paul@...l-moore.com>
> Link: https://lore.kernel.org/all/CAHC9VhQ7A4+msL38WpbOMYjAqLp0EtOjeLh4Dc6SQtD6OUvCQg@mail.gmail.com/
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>
> Notes:
>     This patch has a couple of TOODs, since this is a fix, this is the
>     shortest path to a solution, will do the refactoring later on net-next.
>
>     I hope Paul can test it before tomorrow's net PR, and I will ask Shay to
>     test internally if he could today.
>
>  drivers/net/ethernet/mellanox/mlx5/core/main.c | 14 +++++++++++---
>  include/linux/mlx5/driver.h                    |  7 ++++++-
>  2 files changed, 17 insertions(+), 4 deletions(-)

I'm not sure where this patch stands given the current timing, but I
ran this through my automated testing this morning and everything
looked good on my end.

Tested-by: Paul Moore <paul@...l-moore.com>

-- 
paul-moore.com