netdev - Re: [PATCH net] net: dpaa: Fix uninitialized variable in dpaa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ddeba18-9e11-5a87-4f44-d739d23ce5f5@seco.com>
Date:   Thu, 20 Apr 2023 16:07:05 -0400
From:   Sean Anderson <sean.anderson@...o.com>
To:     "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>,
        Dan Carpenter <dan.carpenter@...aro.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Camelia Alexandra Groza <camelia.groza@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH net] net: dpaa: Fix uninitialized variable in dpaa_stop()

On 4/20/23 13:02, Madalin Bucur (OSS) wrote:
>> -----Original Message-----
>> From: Dan Carpenter <dan.carpenter@...aro.org>
>> Sent: 20 April 2023 15:36
>> To: Sean Anderson <sean.anderson@...o.com>
>> Cc: Madalin Bucur <madalin.bucur@....com>; David S. Miller
>> <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski
>> <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Camelia Alexandra
>> Groza <camelia.groza@....com>; netdev@...r.kernel.org; kernel-
>> janitors@...r.kernel.org
>> Subject: [PATCH net] net: dpaa: Fix uninitialized variable in dpaa_stop()
>> 
>> The return value is not initialized on the success path.
>> 
>> Fixes: 901bdff2f529 ("net: fman: Change return type of disable to void")
>> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
>> ---
>> Applies to net.
>> 
>>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
>> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
>> index 9318a2554056..f96196617121 100644
>> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
>> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
>> @@ -299,7 +299,8 @@ static int dpaa_stop(struct net_device *net_dev)
>>  {
>>  	struct mac_device *mac_dev;
>>  	struct dpaa_priv *priv;
>> -	int i, err, error;
>> +	int i, error;
>> +	int err = 0;
>> 
>>  	priv = netdev_priv(net_dev);
>>  	mac_dev = priv->mac_dev;
>> --
>> 2.39.2
> 
> Acked-by: Madalin Bucur <madalin.bucur@....nxp.com>
> 
> Thank you!

Reviewed-by: Sean Anderson <sean.anderson@...o.com>