netdev - Re: [PATCHv2 next] ipv6: add icmpv6_error_anycast_as

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2023 14:00:56 -0700
From:   Mahesh Bandewar (महेश बंडेवार) 
        <maheshb@...gle.com>
To:     Maciej Żenczykowski <maze@...gle.com>
Cc:     David Ahern <dsahern@...nel.org>, Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Mahesh Bandewar <mahesh@...dewar.net>,
        Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCHv2 next] ipv6: add icmpv6_error_anycast_as_unicast for ICMPv6

On Thu, Apr 20, 2023 at 12:12 PM Maciej Żenczykowski <maze@...gle.com> wrote:
>
> Reviewed-by: Maciej Żenczykowski <maze@...gle.com>
>
> Though I am wondering if it would make more sense to put the check
> inside ipv6_anycast_destination()
> 'treat_anycast_as_unicast' or something.
>
I prefer the current form as it maintains the current semantics of
'ipv6_anycast_destination' which is used at other places as well.

> On Thu, Apr 20, 2023 at 8:55 PM David Ahern <dsahern@...nel.org> wrote:
> >
> > On 4/18/23 7:32 PM, Mahesh Bandewar wrote:
> > > ICMPv6 error packets are not sent to the anycast destinations and this
> > > prevents things like traceroute from working. So create a setting similar
> > > to ECHO when dealing with Anycast sources (icmpv6_echo_ignore_anycast).
> > >
> > > Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>
> > > CC: Maciej Żenczykowski <maze@...gle.com>
> > > ---
> > >  Documentation/networking/ip-sysctl.rst |  7 +++++++
> > >  include/net/netns/ipv6.h               |  1 +
> > >  net/ipv6/af_inet6.c                    |  1 +
> > >  net/ipv6/icmp.c                        | 15 +++++++++++++--
> > >  4 files changed, 22 insertions(+), 2 deletions(-)
> > >
> >
> >
> > Reviewed-by: David Ahern <dsahern@...nel.org>
> >