netdev - Re: [net-next 11/15] net/mlx5e: RX, Hook NAPIs to page pools

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230420191318.1d332ebb@kernel.org>
Date:   Thu, 20 Apr 2023 19:13:18 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Dragos Tatulea <dtatulea@...dia.com>
Subject: Re: [net-next 11/15] net/mlx5e: RX, Hook NAPIs to page pools

On Thu, 20 Apr 2023 18:38:46 -0700 Saeed Mahameed wrote:
> From: Dragos Tatulea <dtatulea@...dia.com>
> 
> Linking the NAPI to the rq page_pool to improve page_pool cache
> usage during skb recycling.
> 
> Here are the observed improvements for a iperf single stream
> test case:
> 
> - For 1500 MTU and legacy rq, seeing a 20% improvement of cache usage.
> 
> - For 9K MTU, seeing 33-40 % page_pool cache usage improvements for
> both striding and legacy rq (depending if the application is running on
> the same core as the rq or not).

I think you'll need a strategically placed page_pool_unlink_napi() once
https://lore.kernel.org/all/20230419182006.719923-1-kuba@kernel.org/
gets merged (which should me in minutes). Would you be able to follow
up on this tomorrow?