netdev - RE: [PATCH net-next v7 4/5] net/mlx5: Consider VLAN interface in MACsec TX steering rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR18MB4666FA3302F0BEB51D7B23EFA1609@CO1PR18MB4666.namprd18.prod.outlook.com>
Date:   Fri, 21 Apr 2023 05:54:23 +0000
From:   Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To:     "ehakim@...dia.com" <ehakim@...dia.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "sd@...asysnail.net" <sd@...asysnail.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "leon@...nel.org" <leon@...nel.org>
Subject: RE: [PATCH net-next v7 4/5] net/mlx5: Consider VLAN interface in
 MACsec TX steering rules



>-----Original Message-----
>From: Emeel Hakim <ehakim@...dia.com> <ehakim@...dia.com>
>Sent: Wednesday, April 19, 2023 7:51 PM
>To: davem@...emloft.net; kuba@...nel.org; pabeni@...hat.com;
>edumazet@...gle.com; sd@...asysnail.net
>Cc: netdev@...r.kernel.org; leon@...nel.org; Emeel Hakim
><ehakim@...dia.com>
>Subject: [PATCH net-next v7 4/5] net/mlx5: Consider VLAN interface in
>MACsec TX steering rules
>
>Offloading MACsec when its configured over VLAN with current MACsec TX
>steering rules will wrongly insert MACsec sec tag after inserting the VLAN
>header leading to a ETHERNET | SECTAG | VLAN packet when ETHERNET |
>VLAN | SECTAG is configured.
>
>The above issue is due to adding the SECTAG by HW which is a later stage
>compared to the VLAN header insertion stage.
>
>Detect such a case and adjust TX steering rules to insert the SECTAG in the
>correct place by using reformat_param_0 field in the packet reformat to
>indicate the offset of SECTAG from end of the MAC header to account for
>VLANs in granularity of 4Bytes.
>
>Signed-off-by: Emeel Hakim <ehakim@...dia.com>

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>