netdev - Re: [PATCH net-next v4 0/4] net/sched: cleanup parsing prints in htb and qfq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230421210805.42a66c21@kernel.org>
Date:   Fri, 21 Apr 2023 21:08:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Pedro Tammela <pctammela@...atatu.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, simon.horman@...igine.com
Subject: Re: [PATCH net-next v4 0/4] net/sched: cleanup parsing prints in
 htb and qfq

On Fri, 21 Apr 2023 14:53:40 -0300 Pedro Tammela wrote:
> These two qdiscs are still using prints on dmesg to report parsing
> errors. Since the parsing code has access to extack, convert these error
> messages to extack.
> 
> QFQ also had the opportunity to remove some redundant code in the
> parameters parsing by transforming some attributes into parsing
> policies.

I haven't investigated in detail but doesn't seem to apply:

Applying: net/sched: sch_htb: use extack on errors messages
Applying: net/sched: sch_qfq: use extack on errors messages
Applying: net/sched: sch_qfq: refactor parsing of netlink parameters
error: patch failed: net/sched/sch_qfq.c:408
error: net/sched/sch_qfq.c: patch does not apply
Patch failed at 0003 net/sched: sch_qfq: refactor parsing of netlink parameters
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
fatal: It looks like 'git am' is in progress. Cannot rebase.

-- 
pw-bot: cr