netdev - Re: [net PATCH 8/9] octeontx2-pf: mcs: Fix shared counters logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230423165427.GK4782@unreal>
Date:   Sun, 23 Apr 2023 19:54:27 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Geetha sowjanya <gakula@...vell.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, richardcochran@...il.com, sgoutham@...vell.com,
        sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [net PATCH 8/9] octeontx2-pf: mcs: Fix shared counters logic

On Sun, Apr 23, 2023 at 03:24:53PM +0530, Geetha sowjanya wrote:
> From: Subbaraya Sundeep <sbhatta@...vell.com>
> 
> Macsec stats like InPktsLate and InPktsDelayed share
> same counter in hardware. If SecY replay_protect is true
> then counter represents InPktsLate otherwise InPktsDelayed.
> This mode change was tracked based on protect_frames
> instead of replay_protect mistakenly. Similarly InPktsUnchecked
> and InPktsOk share same counter and mode change was tracked
> based on validate_check instead of validate_disabled.
> This patch fixes those problems.
> 
> Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/cn10k_macsec.c  | 14 +++++++-------
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |  2 +-
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>