lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <fffb3e6ad76a26a9633728501b5d606864235e65.camel@sipsolutions.net> Date: Mon, 24 Apr 2023 19:31:22 +0200 From: Johannes Berg <johannes@...solutions.net> To: Tejun Heo <tj@...nel.org>, jiangshanlai@...il.com Cc: linux-kernel@...r.kernel.org, kernel-team@...a.com, Kalle Valo <kvalo@...nel.org>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Gregory Greenman <gregory.greenman@...el.com>, Avraham Stern <avraham.stern@...el.com>, Kees Cook <keescook@...omium.org>, Mordechay Goodstein <mordechay.goodstein@...el.com>, "Haim, Dreyfuss" <haim.dreyfuss@...el.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 09/22] wifi: iwlwifi: Use alloc_ordered_workqueue() to create ordered workqueues On Thu, 2023-04-20 at 16:50 -1000, Tejun Heo wrote: > This patch series audits all callsites that create an UNBOUND workqueue w/ > @max_active==1 and converts them to alloc_ordered_workqueue() as necessary. > > WHAT TO LOOK FOR > ================ > > The conversions are from > > alloc_workqueue(WQ_UNBOUND | flags, 1, args..) > > to > > alloc_ordered_workqueue(flags, args...) > > which don't cause any functional changes. If you know that fully ordered > execution is not ncessary, please let me know. I'll drop the conversion and > instead add a comment noting the fact to reduce confusion while conversion > is in progress. This workqueue only has a single work struct queued on it, I'm not _entirely_ sure why there's even a separate workqueue (possibly for priority reasons etc.), but surely with just a single work struct, order cannot really matter. johannes
Powered by blists - more mailing lists