lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230424143651.53137be4@kernel.org> Date: Mon, 24 Apr 2023 14:36:51 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Jamal Hadi Salim <jhs@...atatu.com> Cc: Stephen Hemminger <stephen@...workplumber.org>, Leon Romanovsky <leon@...nel.org>, Victor Nogueira <victor@...atatu.com>, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, xiyou.wangcong@...il.com, jiri@...nulli.us, kernel@...atatu.com Subject: Re: [PATCH net v2] net/sched: act_mirred: Add carrier check On Mon, 24 Apr 2023 13:59:15 -0400 Jamal Hadi Salim wrote: > > Then fix the driver. It shouldn't hang. > > Other drivers just drop packets if link is down. > > We didnt do extensive testing of drivers but consider this a safeguard > against buggy driver (its a huge process upgrading drivers in some > environments). It may even make sense to move this to dev_queue_xmit() > i.e the arguement is: why is the core sending a packet to hardware > that has link down to begin with? BTW, I believe the bridge behaves > this way ... I'm with Stephen, even if the check makes sense in general we should first drill down into the real bug, and squash it. -- pw-bot: cr
Powered by blists - more mailing lists