netdev - RE: [Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant Rx field from rule info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB5013D87A5D3292DB8932C11B96679@PH0PR11MB5013.namprd11.prod.outlook.com>
Date:   Mon, 24 Apr 2023 06:40:55 +0000
From:   "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To:     Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:     "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Simon Horman <simon.horman@...igine.com>
Subject: RE: [Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant
 Rx field from rule info

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Michal Swiatkowski
> Sent: Friday, April 7, 2023 10:22 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: pmenzel@...gen.mpg.de; netdev@...r.kernel.org; Simon Horman
> <simon.horman@...igine.com>
> Subject: [Intel-wired-lan] [PATCH net-next v4 2/5] ice: remove redundant Rx
> field from rule info
> 
> Information about the direction is currently stored in sw_act.flag.
> There is no need to duplicate it in another field.
> 
> Setting direction flag doesn't mean that there is a match criteria for direction
> in rule. It is only a information for HW from where switch id should be
> collected (VSI or port). In current implementation of advance rule handling,
> without matching for direction meta data, we can always set one the same
> flag and everything will work the same.
> 
> Ability to match on direction meta data will be added in follow up patches.
> 
> Recipe 0, 3 and 9 loaded from package has direction match criteria, but they
> are handled in other function.
> 
> Move ice_adv_rule_info fields to avoid holes.
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Reviewed-by: Piotr Raczynski <piotr.raczynski@...el.com>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_eswitch.c |  1 -
> drivers/net/ethernet/intel/ice/ice_switch.c  | 22 ++++++++++----------
> drivers/net/ethernet/intel/ice/ice_switch.h  |  8 +++----
> drivers/net/ethernet/intel/ice/ice_tc_lib.c  |  5 -----
>  4 files changed, 14 insertions(+), 22 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>