netdev - Re: [net-next Patch v9 0/6] octeontx2-pf: HTB offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2023 06:47:31 +0000
From:   Hariprasad Kelam <hkelam@...vell.com>
To:     Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
        Jacob Keller <jacob.e.keller@...el.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Naveen Mamindlapalli <naveenm@...vell.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "jhs@...atatu.com" <jhs@...atatu.com>,
        "xiyou.wangcong@...il.com" <xiyou.wangcong@...il.com>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "maxtram95@...il.com" <maxtram95@...il.com>,
        "corbet@....net" <corbet@....net>
Subject: Re: [net-next Patch v9 0/6] octeontx2-pf: HTB offload support



> On Wed, 2023-04-12 at 18:27 -0700, Jakub Kicinski wrote:
> > On Tue, 11 Apr 2023 14:33:53 +0530 Hariprasad Kelam wrote:
> > > octeontx2 silicon and CN10K transmit interface consists of five
> > > transmit levels starting from MDQ, TL4 to TL1. Once packets are
> > > submitted to MDQ, hardware picks all active MDQs using strict
> > > priority, and MDQs having the same priority level are chosen using
> > > round robin. Each packet will traverse MDQ, TL4 to TL1 levels.
> > > Each level contains an array of queues to support scheduling and
> > > shaping.
> >
> >
> > Looks like Jake's comments from v7 apply.
> 
> Just to be more verbose, the above means clarifying the commit message for
> patch 4/6 and try factor into separate helpers some code of function
> __otx2_qos_txschq_cfg() in patch 6/6.
> 
ACK, will address in next version.

Thanks,
Hariprasad k
> Thanks,
> 
> Paolo