lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <DB9PR05MB90785F1F423F12B4EC5EC78688679@DB9PR05MB9078.eurprd05.prod.outlook.com> Date: Mon, 24 Apr 2023 11:00:05 +0000 From: Tung Quang Nguyen <tung.q.nguyen@...tech.com.au> To: sunichi <sunyiqixm@...il.com>, "jmaloy@...hat.com" <jmaloy@...hat.com> CC: "ying.xue@...driver.com" <ying.xue@...driver.com>, "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "tipc-discussion@...ts.sourceforge.net" <tipc-discussion@...ts.sourceforge.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] tipc: fix a log bug >Subject: [PATCH] tipc: fix a log bug Please rephrase this patch title, what is "log bug" ? > >When tipc stripe \x00 from string hex, it walks step by step >instead of two step. >It will cause a char which ascii low 4 bit is zero be striped. >So change one step iteration to two step to fix this bug. > Please rephrase this change log by correcting typo/grammar and provide printouts of "tipc node list" command to prove unexpected/incorrect node id. >Signed-off-by: sunichi <sunyiqixm@...il.com> If you can prove there is a bug, please add Fixes tag to your patch. >--- > net/tipc/addr.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/net/tipc/addr.c b/net/tipc/addr.c >index fd0796269..83eb91ca3 100644 >--- a/net/tipc/addr.c >+++ b/net/tipc/addr.c >@@ -117,8 +117,10 @@ char *tipc_nodeid2string(char *str, u8 *id) > sprintf(&str[2 * i], "%02x", id[i]); > > /* Strip off trailing zeroes */ >- for (i = NODE_ID_STR_LEN - 2; str[i] == '0'; i--) >+ for (i = NODE_ID_STR_LEN - 2; str[i] == '0' && str[i - 1] == '0'; i -= 2) { > str[i] = 0; >+ str[i - 1] = 0; >+ } > > return str; > } >-- >2.25.1
Powered by blists - more mailing lists