lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <077d3578-4475-4195-9018-392edd34d4e5@lunn.ch> Date: Mon, 24 Apr 2023 13:56:36 +0200 From: Andrew Lunn <andrew@...n.ch> To: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com> Cc: Jakub Kicinski <kuba@...nel.org>, hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix the PTP interrupt enabling/disabling > > Also why ignore the return value? > This register might not be present on every PHY, that's why the return value > is ignored. Please document that, otherwise you might see people add code to check the return value. Or better, still, differentiate between the different versions, and only touch it when it does exist. Andtrew
Powered by blists - more mailing lists