netdev - Re: [PATCH net-next] net: stmmac: allow ethtool action on PCI devices if device is down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEj79PLEcn7Q78T5@calimero.vinschen.de>
Date:   Wed, 26 Apr 2023 12:24:52 +0200
From:   Corinna Vinschen <vinschen@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: stmmac: allow ethtool action on PCI
 devices if device is down

On Apr 25 06:54, Jakub Kicinski wrote:
> On Tue, 25 Apr 2023 10:14:01 +0200 Corinna Vinschen wrote:
> > is that patch still under review or is it refused, given the
> > current behaviour is not actually incorrect?
> 
> That's not what Heiner said. Does the device not link the netdev
> correctly to the bus device?

No, that's not the problem.

> Core already does pm_get/pm_put
> around ethtool calls.

Yeah, right.  I made a more thorough test now and it appears that
the calls don't even have any effect.

For testing I created a driver which simply skips the check for
netdev_running() and compared with the driver including my patch.
I tested almost all ethtool calls fetching and setting values and
there's no difference in behaviour.

Worse, while it's possible to change a lot of settings when skipping the
netdev_running() check, , some really basic stuff doesn't work as
desired.  I. e., setting autoneg or a fixed speed while the interface is
down is taken without complaints, but it has no effect when the
interface goes up again.

So we can just scratch my patch.  Sorry wasting your time.

Corinna