netdev - Re: dsa: mv88e6xxx: mv88e6321 rsvd2cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230426132303.frxluy56dxi7ofbv@skbuf>
Date:   Wed, 26 Apr 2023 16:23:03 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Angelo Dureghello <angelo@...nel-space.org>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>
Subject: Re: dsa: mv88e6xxx: mv88e6321 rsvd2cpu

Hi Angelo,

On Wed, Apr 26, 2023 at 10:12:28AM +0200, Angelo Dureghello wrote:
> Hi all,
> 
> working on some rstp stuff at userspace level, (kernel stp
> disabled), i have seen bpdu packets was forwarded over bridge
> ports generating chaos and loops. As far as i know, 802.1d asks
> bpdus are not forwarded.
> 
> Finally found a solution, adding mv88e6185_g2_mgmt_rsvd2cpu()
> for mv88e6321.
> Is it a proper solution ? Is there any specific reason why
> rsvd2cpu was not implemented for my 6321 ?
> I can send the patch i am using actually. in case.

I don't know why mv88e6321_ops doesn't define a mgmt_rsvd2cpu()
implementation. I would agree that it is necessary, if available.