netdev - Re: [PATCH net 1/3] ice: Fix stats after PF reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230426065026.GH27649@unreal>
Date:   Wed, 26 Apr 2023 09:50:26 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Nguyen <anthony.l.nguyen@...el.com>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        Ahmed Zaki <ahmed.zaki@...el.com>,
        Alexander Lobakin <aleksander.lobakin@...el.com>,
        Rafal Romanowski <rafal.romanowski@...el.com>
Subject: Re: [PATCH net 1/3] ice: Fix stats after PF reset

On Tue, Apr 25, 2023 at 10:01:25AM -0700, Tony Nguyen wrote:
> From: Ahmed Zaki <ahmed.zaki@...el.com>
> 
> After a core PF reset, the VFs were showing wrong Rx/Tx stats. This is a
> regression in commit 6624e780a577 ("ice: split ice_vsi_setup into smaller
> functions") caused by missing to set "stat_offsets_loaded = false" in the
> ice_vsi_rebuild() path.
> 
> Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_lib.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>